Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

person_id has to be nullable because bots use NULL. #7057

Merged
merged 1 commit into from Feb 13, 2020
Merged

person_id has to be nullable because bots use NULL. #7057

merged 1 commit into from Feb 13, 2020

Conversation

bakert
Copy link
Member

@bakert bakert commented Feb 13, 2020

No description provided.

@vorpal-buildbot vorpal-buildbot merged commit bd981ca into master Feb 13, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020 •
edited

Codecov Report

Merging #7057 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7057      +/-   ##
==========================================
+ Coverage   45.56%   45.67%   +0.11%     
==========================================
  Files         274      274              
  Lines       13737    13737              
  Branches     2058     2058              
==========================================
+ Hits         6259     6275      +16     
+ Misses       7184     7173      -11     
+ Partials      294      289       -5
Impacted Files Coverage Δ
magic/image_fetcher.py 35.66% <0%> (ø) ⬆️
decksite/league.py 34.43% <0%> (-0.34%) ⬇️
maintenance/elo.py 0% <0%> (ø) ⬆️
decksite/view.py 60.79% <0%> (ø) ⬆️
decksite/views/person_achievements.py 35% <0%> (ø) ⬆️
decksite/data/rule.py 23.42% <0%> (ø) ⬆️
decksite/data/deck.py 64.52% <0%> (+0.67%) ⬆️
decksite/data/archetype.py 50.92% <0%> (+1.84%) ⬆️
magic/legality.py 88.65% <0%> (+2.06%) ⬆️
decksite/scrapers/gatherling.py 83.87% <0%> (+3.22%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d3def...1f85726. Read the comment docs.

@vorpal-buildbot vorpal-buildbot added Pending-on-LOGS Used by the build bot Pending-on-PROD Used by the build bot Seen-on-LOGS Seen-on-PROD and removed Pending-on-LOGS Used by the build bot Pending-on-PROD Used by the build bot labels Feb 13, 2020
@vorpal-buildbot
Copy link
Contributor

Seen on LOGS, PROD (created by @bakert and merged by @vorpal-buildbot 19 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Seen-on-LOGS Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bakert @vorpal-buildbot